This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 229
Update GitHub statuses API for commits #5
Labels
Comments
Can take this |
@iyovcheva do you have an update on this or is it available for someone else to work on? |
I didn't have a look yet. Happy to work on this, but it's not on top of the priority list, so if someone Please write a comment, so that we don't duplicate efforts. |
For OpenFaaS Cloud to be useful this is definitely high priority. We need a way of providing feedback. I'll add a a label. |
I'll be happy to work on it :) |
@s8sg thanks for working on this. I've added some more notes since this is going to require auth we have to pull in some new code. I'd suggest using the work from Derek - vendor it if you can. |
Derek close: PR is merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We can update GitHub statuses API for commits and give feedback on whether a push / deployment succeeded or failed.
This needs an extended OAuth permission for the GitHub App to write commit statuses - everyone will have to accept the new permissions to update commit statuses on their repos
The Golang GitHub library used with Derek should be able to do this - vendor it if it's not already there
We have to authenticate to the GitHub API to write a status - use the Derek code that
We have to use a cert/pem from the GitHub App - use a secret to store it on Docker/Kubernetes and updated the README with instructions on how to use it
We need a description for events to go back to GitHub - keep this brief right now just pass or fail will do
We have to extend the JSON "push message" structs to accept the installation ID - this is needed so we can authenticate later into an "installation - i.e. a GitHub repo". See the Derek package and vendor if needed.
I would suggest writing the status back via the final buildshiprun function (it will need the pem/cert secret attaching to it)
The text was updated successfully, but these errors were encountered: