Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Update GitHub statuses API for commits #5

Closed
alexellis opened this issue Apr 1, 2018 · 7 comments
Closed

Update GitHub statuses API for commits #5

alexellis opened this issue Apr 1, 2018 · 7 comments

Comments

@alexellis
Copy link
Member

alexellis commented Apr 1, 2018

We can update GitHub statuses API for commits and give feedback on whether a push / deployment succeeded or failed.

  • This needs an extended OAuth permission for the GitHub App to write commit statuses - everyone will have to accept the new permissions to update commit statuses on their repos

  • The Golang GitHub library used with Derek should be able to do this - vendor it if it's not already there

  • We have to authenticate to the GitHub API to write a status - use the Derek code that

  • We have to use a cert/pem from the GitHub App - use a secret to store it on Docker/Kubernetes and updated the README with instructions on how to use it

  • We need a description for events to go back to GitHub - keep this brief right now just pass or fail will do

  • We have to extend the JSON "push message" structs to accept the installation ID - this is needed so we can authenticate later into an "installation - i.e. a GitHub repo". See the Derek package and vendor if needed.

I would suggest writing the status back via the final buildshiprun function (it will need the pem/cert secret attaching to it)

@ivanayov
Copy link
Contributor

ivanayov commented Apr 2, 2018

Can take this

@alexellis
Copy link
Member Author

@iyovcheva do you have an update on this or is it available for someone else to work on?

@ivanayov
Copy link
Contributor

I didn't have a look yet. Happy to work on this, but it's not on top of the priority list, so if someone
wants to take it - feel free.

Please write a comment, so that we don't duplicate efforts.

@alexellis
Copy link
Member Author

t it's not on top of the priority list

For OpenFaaS Cloud to be useful this is definitely high priority. We need a way of providing feedback. I'll add a a label.

@s8sg
Copy link
Contributor

s8sg commented Apr 23, 2018

I'll be happy to work on it :)

@alexellis
Copy link
Member Author

@s8sg thanks for working on this. I've added some more notes since this is going to require auth we have to pull in some new code. I'd suggest using the work from Derek - vendor it if you can.

@ericstoekl
Copy link
Contributor

Derek close: PR is merged

@derek derek bot closed this as completed May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants