-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenFaas function for face detection #38
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. |
…face detection library. Signed-off-by: esimov <esimovaq@yahoo.com>
Thanks @esimov Can you please compare with face-detect? |
They look very close. Please could you try some other images? No need to provide screenshots just URLs and results. Could you also match the highlight colour? The red is hard for people with colourblindness to see. |
You mean to change the box color to yellow? |
Adjusted the highlight color to be yellow. |
Please could you rename your Git repo to pigo-openfaas? openfaas- prefixes are reserved for the project official use. Thanks 👍 |
store.json
Outdated
{ | ||
"title": "OpenFaaS Function for Face Detection", | ||
"description": "Detect faces in images using the Pigo face detection library. You provide an image URI and the function draws boxes around the detected faces.", | ||
"image": "esimov/openfaas-pigo:latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esimov/pigo-openfaas:0.1
store.json
Outdated
@@ -216,5 +216,21 @@ | |||
"name": "sentimentanalysis", | |||
"network": "func_functions", | |||
"repo_url": "https://github.com/openfaas/faas/tree/master/sample-functions/SentimentAnalysis" | |||
}, | |||
{ | |||
"title": "OpenFaaS Function for Face Detection", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just: Face Detection with Pigo
store.json
Outdated
"image": "esimov/openfaas-pigo:latest", | ||
"name": "face-detect", | ||
"network": "func_functions", | ||
"repo_url": "https://github.com/esimov/openfaas-pigo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esimov/openfaas-pigo
-> esimov/pigo-openfaas
store.json
Outdated
"title": "OpenFaaS Function for Face Detection", | ||
"description": "Detect faces in images using the Pigo face detection library. You provide an image URI and the function draws boxes around the detected faces.", | ||
"image": "esimov/openfaas-pigo:latest", | ||
"name": "face-detect", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
face-detect-pigo
(we already have face-detect`)
@esimov while you're doing the edits please can you update the existing face-detect to say "with OpenCV" in its title? |
Signed-off-by: esimov <esimovaq@yahoo.com>
@alexellis all the required changes have been done. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please include the face detection function into the FaaS store.