New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate python3-debian from incubator #197
Conversation
**What** - Copy the python3-debian template from https://github.com/openfaas-incubator/python3-debian - Update the dockerfile to be non-root, this adapts the same modifications/commands that the alpine dockerfile uses, but ofcourse adapted to debian Resolves openfaas-incubator/python3-debian#10 Resolves openfaas-incubator/python3-debian#7 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
**What** - Moves the python3-debian template to the main templates repo Depends on openfaas/templates#197 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Approved, just need the README table to be updated next. |
In this PR ideally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for after upstream PR merged in templates repo
Updates the readme to include the new python3-debian in the list Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@alexellis i just updated the readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Thank you for the PR 👍 |
**What** - Moves the python3-debian template to the main templates repo Depends on openfaas/templates#197 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Description
modifications/commands that the alpine dockerfile uses, but of course adapted to debian
Motivation and Context
Which issue(s) this PR fixes
Fixes openfaas-incubator/python3-debian#10
Fixes openfaas-incubator/python3-debian#7
How Has This Been Tested?
I tested it by creating a new echo function
faas-cli new echo --lang python3-debian
I then built it using
I then verified that
ADDITIONAL_PACKAGE
worked as expected usingThe last command verifies that build-essential installed correctly .
Types of changes
Impact to existing users
Checklist:
git commit -s