Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate python3-debian from incubator #197

Merged
merged 2 commits into from Feb 6, 2020

Conversation

LucasRoesler
Copy link
Member

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes openfaas-incubator/python3-debian#10
Fixes openfaas-incubator/python3-debian#7

How Has This Been Tested?

I tested it by creating a new echo function

faas-cli new echo --lang python3-debian

I then built it using

$ faas-cli build -f echo.yml 
$ docker run --rm -d -p 8080:8080 echo:latest
$ curl http://localhost:8080 -d "this is a test message"
this is a test message

I then verified that ADDITIONAL_PACKAGE worked as expected using

faas-cli build -f echo.yml --build-arg ADDITIONAL_PACKAGE='curl build-essential'
$ docker run --rm -d -p 8080:8080 echo:latest
$ curl http://localhost:8080 -d "this is a test message"
this is a test message
$ docker run --rm echo:latest which make
/usr/bin/make

The last command verifies that build-essential installed correctly .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

**What**
- Copy the python3-debian template from https://github.com/openfaas-incubator/python3-debian
- Update the dockerfile to be non-root, this adapts the same
  modifications/commands that the alpine dockerfile uses, but ofcourse
  adapted to debian

Resolves openfaas-incubator/python3-debian#10
Resolves openfaas-incubator/python3-debian#7

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
LucasRoesler added a commit to LucasRoesler/store that referenced this pull request Feb 5, 2020
**What**
- Moves the python3-debian template to the main templates repo

Depends on openfaas/templates#197

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis
Copy link
Member

Approved, just need the README table to be updated next.

@alexellis
Copy link
Member

In this PR ideally

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for after upstream PR merged in templates repo

Updates the readme to include the new python3-debian in the list

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
@LucasRoesler
Copy link
Member Author

@alexellis i just updated the readme

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 702014e into openfaas:master Feb 6, 2020
@alexellis
Copy link
Member

Thank you for the PR 👍

alexellis pushed a commit to openfaas/store that referenced this pull request Feb 6, 2020
**What**
- Moves the python3-debian template to the main templates repo

Depends on openfaas/templates#197

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse into the main templates repo Urgent - convert to non-root runtime user
2 participants