Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make templates multi-arch #227

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Make templates multi-arch #227

merged 1 commit into from
Nov 17, 2020

Conversation

utsavanand2
Copy link
Contributor

Signed-off-by: Utsav Anand utsavanand2@gmail.com

Description

Change the following templates to support multi-arch buildx builds:
go
node
node12
php7
python
python3
python3-debian
ruby

Motivation and Context

The PR will add the freedom to build and deploy OpenFaaS function to multiple CPU architectures.
Functions can be built locally or a CI env like Github Actions which supports buildx, and deployed on most common architectures, like amd64, arm64, or armv7

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #226

How Has This Been Tested?

Screenshot 2020-10-25 at 9 20 27 PM

Screenshot 2020-10-25 at 9 26 57 PM

Screenshot 2020-10-25 at 9 39 47 PM

Screenshot 2020-10-25 at 10 09 58 PM

Screenshot 2020-10-25 at 10 16 00 PM

Screenshot 2020-10-25 at 10 43 09 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

No user impact to existing users because of the tests we have been running for the incubator templates, running functions across environments and architectures.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

utsavanand2 added a commit to utsavanand2/templates that referenced this pull request Oct 25, 2020
Fixes openfaas#227

Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
Fixes openfaas#226

Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexellis alexellis merged commit 8a284e1 into openfaas:master Nov 17, 2020
@alexellis alexellis removed the request for review from Waterdrips November 17, 2020 14:39
@alexellis
Copy link
Member

@Waterdrips you should be able to use this change along with faas-cli publish to get multi-arch functions for OpenFaaS Cloud. Can you have a play and let us know if anything else needs changing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-arch builds of OpenFaaS functions with buildx
2 participants