Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH actions by using bash not sh #229

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix GH actions by using bash not sh #229

merged 1 commit into from
Nov 9, 2020

Conversation

Waterdrips
Copy link
Contributor

@Waterdrips Waterdrips commented Nov 7, 2020 •
edited
Loading

Description

Change the makefile to use bash not sh for the script.

Turns out my laptop has sh symlinked to bash so that's why make worked locally

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Motivation and Context

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #

How Has This Been Tested?

see check suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Waterdrips
Fix actions by using bash
dd521b9 
useing bask in the makefile to fix actions not working

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
@Waterdrips Waterdrips changed the title Fix docker missing on GH actions Fix GH actions by using bask not sh Nov 7, 2020
@Waterdrips Waterdrips changed the title Fix GH actions by using bask not sh Fix GH actions by using bash not sh Nov 7, 2020
alexellis
alexellis approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 2e630fd into openfaas:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Waterdrips @alexellis