Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to build all branches and PRs #230

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

CodeCutterUK
Copy link
Contributor

Description

The OpenFaas approach is to build on all branches and PRs via GitHub Actions. This PR updates this repo to follow that pattern

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

https://github.com/openfaas/templates/actions/runs/354389027

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mark Ison <mark@codecutter.uk>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 624efe5 into openfaas:master Nov 10, 2020
@CodeCutterUK CodeCutterUK deleted the github-actions branch November 10, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants