Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable raw limit #247

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Add configurable raw limit #247

merged 1 commit into from
Feb 10, 2021

Conversation

alexellis
Copy link
Member

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Description

Add configurable raw limit

Motivation and Context

This change means users can send a raw body of over 100KB, previously the body-parser middleware was restricting this size.

Which issue(s) this PR fixes

Fixes: #245
Closes: #246

How Has This Been Tested?

Tested by the user in #245 and by another user on Slack who also asked for this today.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

A change will be required in the openfaas/docs repo.

Fixes: #245
Closes: #246

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit 668ebe7 into master Feb 10, 2021
@alexellis alexellis deleted the add_raw_limit branch February 10, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node12: add limit environment variable for raw (application/octet-stream)
1 participant