Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java11-vert-x: words correct: java8 -> java11 #248

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

moqimoqidea
Copy link
Contributor

Just words correct.

@derek derek bot added the new-contributor label Mar 1, 2021
@derek
Copy link

derek bot commented Mar 1, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Mar 1, 2021
@alexellis
Copy link
Member

Hi @moqimoqidea, you'll need to follow the command Derek gave you, or we can close the PR and you can raise an issue instead.

Let me know which option you prefer?

Alex

Signed-off-by: moqi <moqimoqidea@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis
Copy link
Member

Thanks for the PR

@alexellis alexellis merged commit b8d9e03 into openfaas:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants