Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation fix - links to node12 and node14 in README.md #251

Merged
merged 1 commit into from Apr 6, 2021

Conversation

ggrussenmeyer
Copy link

Description

Fixed hyperlinks to node12 and node14 templates source code so that they are located in the matching template row.

Motivation and Context

Minor documentation issue that can be confusing.

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #250.

How Has This Been Tested?

  • Browsed README.md in the adequate branch on github.com ;
  • Clicked the links ;
  • Verified that the correct directory was displayed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixed links to template directory for node12 and node14.

Signed-off-by: Guillaume Grussenmeyer <ggrussenmeyer@protonmail.com>
@derek derek bot added the new-contributor label Apr 2, 2021
@ggrussenmeyer ggrussenmeyer changed the title Fixes #250. Minor documentation fix - links to node12 and node14 in README.md Apr 2, 2021
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you

@alexellis alexellis merged commit 813e2dc into openfaas:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inversion in README.md for node12 and node14 links
2 participants