Fixes node14 Dockerfile to reference the correct Node.js Docker image version #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Grussenmeyer ggrussenmeyer@protonmail.com
Description
Update
node
Docker image version to14-alpine
innode14/Dockerfile
(was12-alpine
).Motivation and Context
Which issue(s) this PR fixes
Fixes #253
How Has This Been Tested?
By verifying the output of
docker run node14-ci node --version
.Types of changes
Impact to existing users
Users that thought they were running Node.js v14 when using the
node14
template were actually running v12.After this PR they'll be actually running v14.
I'm unable to evaluate the effective impact; YMMV.
Checklist:
git commit -s