Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user group for Ruby #43

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Conversation

ivanayov
Copy link
Contributor

@ivanayov ivanayov commented Jul 9, 2018

This fixes ruby template to set app group properly.
Before used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) iyovcheva@vmware.com

Motivation and Context

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #41

How Has This Been Tested?

Manually tested with docker run -ti <image> sh and by building function template.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This fixes ruby template to set app group properly. Fixes
[openfaas#41](openfaas#41). Before
used to add GEO data for user, after the change adds group to user

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@alexellis alexellis merged commit e12758a into openfaas:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong flag set for group in non-root users
2 participants