Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-armhf template to use non-root user #46

Merged
merged 1 commit into from Feb 5, 2020

Conversation

ivanayov
Copy link
Contributor

@ivanayov ivanayov commented Jul 9, 2018

This updates the node-armhf function template to use a non-root
user. Creates app system user and app group

Signed-off-by: Ivana Yovcheva (VMware) iyovcheva@vmware.com

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #23 #41

How Has This Been Tested?

Local build of simple node-armhf function

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This updates the node-armhf function template to use a non-root
user. Creates `app` system user  and `app` group

Signed-off-by: Ivana Yovcheva (VMware) <iyovcheva@vmware.com>
@ivanayov ivanayov force-pushed the nodearm_edit_group branch 2 times, most recently from 14845b0 to a151b89 Compare July 10, 2018 08:40
@alexellis
Copy link
Member

I'd like to see this tested on ARM on an Scaleway C1 instance or just a regular Raspberry Pi (only Docker is needed, not OpenFaaS/Swarm or Kubernetes)

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 94e53f4 into openfaas:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check all usages of root in templates
2 participants