Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more control on the migration job hook #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aballet
Copy link
Contributor

@aballet aballet commented Jun 7, 2024

I made the migration job hook configurable, so that it can be completely deleted.

Description

The rationale is that if someone deploys the chart with the --wait flag of helm, the deployment will wait forever (see #120).
We must remove the hook to solve this. The PR provides a way to do this without breaking changes.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant