-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional way to override timestamp format in json logs #1330
Conversation
Going to close #1329 in favor of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like Jon said, let's keep the backward compatibility. Otherwise lgtm. We'll have to think where to add a test for this. TestCheckLogs
already asserts on some fields logged, but I fear that test is becoming too bloated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default needs to be Unix.
c78f76b
to
5513f81
Compare
@jon-whit @miparnisari I have pushed a commit defaulting to |
5513f81
to
621d5a0
Compare
d8b41d0
to
cb65f4a
Compare
@raj-saxena left one last comment. Looks good otherwise. Thanks! |
Updated the PR @jon-whit. Let's move this forward 🙏🏼 |
Description
I opened an issue earlier where @jon-whit agreed (#1326 (comment)) that moving towards ISO8601 is a better option.
As such, I raised a PR earlier #1329 where @jon-whit raised a valid point (#1329 (comment)) that we should not break compatibility for any existing users.
I have made the changes accordingly in this PR making ISO8601 as the default format while giving an option to enable the older option too if someone wants that. I understand that this could be a breaking change for some users but in the long run, I believe, this would be a step in the right direction.(adjusted to keepUnix
as default after review comments)Verified visually (since there was no test for this)
References
Fixes #1326 while addressing the comment from @jon-whit
#1329 (comment)
Review Checklist
main