enhancement: Refactor NewLogger with options builder pattern #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
+ Coverage 83.83% 85.42% +1.59%
==========================================
Files 85 85
Lines 9850 8016 -1834
==========================================
- Hits 8257 6847 -1410
+ Misses 1239 821 -418
+ Partials 354 348 -6 ☔ View full report in Codecov by Sentry. |
adriantam
reviewed
Mar 4, 2024
adriantam
reviewed
Mar 4, 2024
adriantam
reviewed
Mar 4, 2024
adriantam
reviewed
Mar 4, 2024
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
Fix typo Re-add remove white space Signed-off-by: mevrin <matthieu.evrin@gmail.com>
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
lekaf974
force-pushed
the
use-options-builder-new-logger
branch
from
ed58e2b
to
04010c2
Compare
adriantam
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1355
References
Commented in #1330