Fix YamlItem in test_runner.py to clone TBS in case of reforms #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillett
reviewed
May 4, 2023
| @@ -22,7 +22,7 @@ def get_package_metadata(self): | |||
| return {"name": "Test", "version": "Test"} | |||
|
|
|||
| def apply_reform(self, path): | |||
| return Reform(self) | |||
guillett
approved these changes
May 4, 2023
guillett
reviewed
May 4, 2023
CHANGELOG.md
Outdated
| #### Technical changes | ||
|
|
||
| - Method `_get_tax_benefit_system()` of class `YamlItem` in file `openfisca_core/tools/test_runner.py` will now clone the TBS when applying reforms. | ||
| - Tests in `tests/core/tools/test_runner/test_yaml_runner.py` where not testing properly when applying reforms. |
There was a problem hiding this comment.
Suggested change
| - Tests in `tests/core/tools/test_runner/test_yaml_runner.py` where not testing properly when applying reforms. |
Allan-CodeWorks
force-pushed
the
fix_test_runner_reform_clone
branch
2 times, most recently
from
0d50901
to
ea205d1
Compare
- La methode de test apply_reform() renvoyer une nouvelle instance de la réforme donc les tests étaient bisaisés.
Allan-CodeWorks
force-pushed
the
fix_test_runner_reform_clone
branch
from
ea205d1
to
e473b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical changes
_get_tax_benefit_system()of classYamlItemin fileopenfisca_core/tools/test_runner.pywill now clone the TBS when applying reforms to avoid running tests with previously reformed TBS.Notes
In the case we want to run 2 tests or more with differents
reformsand noextensionswe were sharing the same baseline so we were executing following tests with the TBS set in previous tests.