Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends assert_near to date comparison #973

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Extends assert_near to date comparison #973

merged 2 commits into from
Feb 17, 2021

Conversation

benjello
Copy link
Member

Technical changes

  • Extends assert_near to date comparison

@benjello
Copy link
Member Author

@sandcha : I do nt understand the test erros since it seems unrelated to my changes. any hints @sandcha ?

@sandcha
Copy link
Collaborator

sandcha commented Feb 12, 2021

Hi @benjello , As the error is thrown on this test:

def test_parameter_node():
        response = subject.get('/parameter/benefits')
...

and the last update of the openfisca/country-template#99 adds a openfisca_country_template/parameters/benefits/parenting_allowance.yaml, which comes with a minor update of the package, it looks like a test that is close to the implementation and that we can update to avoid this type of situation.

@benjello
Copy link
Member Author

@sandcha : tests pass now ! You can review ;-)

Copy link
Collaborator

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx @benjello!
Please don't forget to update with a rebase and, in the best of all possible worlds, set the name of the PR as message for the merging commit :)

openfisca_core/tools/__init__.py Show resolved Hide resolved
@@ -1,5 +1,11 @@
# Changelog

### 35.1.0 [#973](https://github.com/openfisca/openfisca-core/pull/973)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder: bump needed (+ only 2 #)

@benjello benjello merged commit a8d9194 into master Feb 17, 2021
@benjello benjello deleted the asser_near_date branch February 17, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants