Fix du script qui détermine le besoin d'un bump de version #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference was outdated, so script fails when not finding the script file.
|
@ClaireLeroyIPP :: peux-tu rajouter ton changelog et ton bump de version ici. |
Anna-Livia
requested changes
Jul 6, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Changelog | |||
|
|
|||
| ### 21.12.2 [#1030](https://github.com/openfisca/openfisca-france/pull/1031) | |||
There was a problem hiding this comment.
Il n'y a pas besoin de changement de version/changelog pour une modification de la config circle. Cependant, si on le fait, Il faut mettre à jour la description du changement.
There was a problem hiding this comment.
Mais c'est pour rattraper un bump manquant qui n'a pas été détecté par les tests
benjello
approved these changes
Jul 6, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,14 @@ | |||
| # Changelog | |||
|
|
|||
| ### 21.12.2 [#1030](https://github.com/openfisca/openfisca-france/pull/1031) | |||
There was a problem hiding this comment.
Mais c'est pour rattraper un bump manquant qui n'a pas été détecté par les tests
Anna-Livia
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.circleci/is-version-number-acceptable.sh b/.circleci/is-version-number-acceptable.sh.Ces changements (effacez les lignes ne correspondant pas à votre cas) :
Quelques conseils à prendre en compte :
Documentez votre contribution avec des références législatives.Mettez à jour ou ajoutez des tests correspondant à votre contribution.setup.py.CHANGELOG.md.Et surtout, n'hésitez pas à demander de l'aide ! :)