-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the scripts compatible with py3 #1053
Conversation
facb9ea
to
9a04dd2
Compare
Ok, the tests were passing because in circleCI it's only specifically running I also realized that the |
d85897c
to
3d34c71
Compare
This is now ready to review <3 |
CHANGELOG.md
Outdated
|
||
* Amélioration technique. | ||
* Détails : | ||
- Rends tous les scripts compatibles avec Python 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'édite le changelog, pour expliciter que le modèle était compatible avec Python3, mais pas certains scripts additionnels.
The France model was already compatible with Python 3, but true, many additional scripts were not, thanks for dealing with that! The makefile is a mess, and no one was brave enough to flake OpenFisca France after years of laxness. |
bf5846e
to
5c986e5
Compare
Rebased, waiting for the tests to pass to merge |
Could you fix the conflicts @magopian? |
5c986e5
to
34e398d
Compare
This is a very straightforward change involving mainly adding parens to the print statements.
The non-trivial changes are in openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py and openfisca_france/scripts/parameters/baremes_ipp/yaml_raw_to_yaml_clean.py:
changing
ur
tor
in regexes.I'm really baffled that those tests would pass without failing in py3 on circleCI previously ...