-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests de la revalorisation de l'ASPA de 2018-04 #1103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci beaucoup @frtomas pour cette PR. Quelques demandes de modifications cosmétiques et c'est bon pour moi.
ressortissant_eee: false | ||
duree_possession_titre_sejour: 0 | ||
output_variables: | ||
aspa: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il manque un saut de ligne à la fin du fichier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guillet Corrections apportées, je m'en suis rendu compte immédiatement après la demande de review
CHANGELOG.md
Outdated
* Périodes concernées : à partir du 01/04/2018. | ||
* Zones impactées : `tests/formulas/aspa`. | ||
* Détails : | ||
- Ajoute des tests pour la revalorisation de l'ASPA (voir PR #1066) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La référence à la PR #1066 pourrait être faite comme pour les autres références ie.
[#1066](https://github.com/openfisca/openfisca-france/pull/1066)
f9cfe7d
to
d7d7310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @frtomas , je te laisse faire un rebase --i --autosquash
pour regrouper les commits et je merge ensuite. OK ?
1053eef
to
d646a22
Compare
@guillet ok, c'est fait, pushé, validé |
tests/formulas/aspa
.Ces changements :