Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests de la revalorisation de l'ASPA de 2018-04 #1103

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Conversation

frtomas
Copy link
Contributor

@frtomas frtomas commented Aug 28, 2018


Ces changements :

  • Modifient des éléments non fonctionnels de ce dépôt (par exemple modification du README).

@frtomas frtomas requested a review from guillett August 28, 2018 13:45
Copy link
Member

@guillett guillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup @frtomas pour cette PR. Quelques demandes de modifications cosmétiques et c'est bon pour moi.

ressortissant_eee: false
duree_possession_titre_sejour: 0
output_variables:
aspa: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il manque un saut de ligne à la fin du fichier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillet Corrections apportées, je m'en suis rendu compte immédiatement après la demande de review

CHANGELOG.md Outdated
* Périodes concernées : à partir du 01/04/2018.
* Zones impactées : `tests/formulas/aspa`.
* Détails :
- Ajoute des tests pour la revalorisation de l'ASPA (voir PR #1066)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La référence à la PR #1066 pourrait être faite comme pour les autres références ie.

[#1066](https://github.com/openfisca/openfisca-france/pull/1066)

@frtomas frtomas added the contrib:msa Identification des sujets MSA label Aug 28, 2018
Copy link
Member

@guillett guillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @frtomas , je te laisse faire un rebase --i --autosquash pour regrouper les commits et je merge ensuite. OK ?

@frtomas
Copy link
Contributor Author

frtomas commented Aug 28, 2018

@guillet ok, c'est fait, pushé, validé

@guillett guillett merged commit 0fd95af into master Aug 28, 2018
@guillett guillett deleted the msa_test_reval_aspa branch August 28, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib:msa Identification des sujets MSA kind:improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants