Simplify boilerplate #697
Merged
Simplify boilerplate #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpagnoux
force-pushed
the
simplify-boilerplate
branch
from
833dd96
to
4c1be16
Compare
fpagnoux
commented
Mar 8, 2017
CHANGELOG.md
Outdated
| ### 14.1.1 - [#697](https://github.com/openfisca/openfisca-france/pull/697) | ||
|
|
||
| * Amélioration technique | ||
| * Utilise le module `core.formulas_toolbox` plutôt que de réimporter un par un tous les objets python nécessaire pour écrire une formule |
fpagnoux
commented
Mar 8, 2017
openfisca_france/model/base.py
Outdated
| from openfisca_core.formula_helpers import apply_thresholds, switch | ||
| from openfisca_core.periods import MONTH, YEAR, ETERNITY | ||
|
|
||
| from openfisca_core.formula_toolbox import * |
There was a problem hiding this comment.
We can replace the import * by __all__.extend(openfisca_core.module_api.__all__)
There was a problem hiding this comment.
But at the same time it's much less clear 🤔
cbenz
reviewed
Mar 9, 2017
openfisca_france/model/base.py
Outdated
| from openfisca_core.formula_helpers import apply_thresholds, switch | ||
| from openfisca_core.periods import MONTH, YEAR, ETERNITY | ||
|
|
||
| from openfisca_core.module_api import * |
There was a problem hiding this comment.
Did you rename model_api to module_api willingly?
cbenz
requested changes
Mar 9, 2017
CHANGELOG.md
Outdated
| ### 14.1.1 - [#697](https://github.com/openfisca/openfisca-france/pull/697) | ||
|
|
||
| * Amélioration technique | ||
| * Utilise le module `core.model_api` plutôt que de réimporter un par un tous les objets python nécessaire pour écrire une formule |
There was a problem hiding this comment.
Typos :
- python -> Python
- nécessaire -> nécessaires
|
5 fixups pour 2 commits, donc un de changelog. Ne plus ouvrir de PR le soir avant de partir ;) |
cbenz
approved these changes
Mar 9, 2017
fpagnoux
force-pushed
the
simplify-boilerplate
branch
from
ce86e09
to
1a40477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply openfisca/openfisca-core#467 to
france.