Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests parallely in Circle CI #762

Merged
merged 4 commits into from
May 31, 2017
Merged

Run tests parallely in Circle CI #762

merged 4 commits into from
May 31, 2017

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented May 23, 2017

Depends on openfisca/openfisca-core#516
Connected to #734

Pas trop d'enthousiasme : une fois qu'on aura ré-introduit les tests, le build sera long de nouveau ;)

  • Détails :
    • Accélère le build grace au parallélisme de Circle CI

Ces changements :

  • Modifient des éléments non fonctionnels de ce dépôt.

Preuve que ça fonctionne :

  • Sur le dernier build de master, on dénombre 1178 tests.
  • Sur ce build, on a:
    • Container 0: 13 tests python + 273 tests yaml
    • Container 1: 13 tests python + 269 tests yaml
    • Container 2: 64 tests python + 269 tests yaml
    • Container 3: 9 tests python + 268 tests yaml
    • Soit un total de... 1178 🎉 💃

@fpagnoux fpagnoux requested a review from MattiSG May 23, 2017 20:28
@fpagnoux fpagnoux changed the title Circle parallel Run tests parallely in Circle CI May 23, 2017
@fpagnoux fpagnoux requested a review from cbenz May 23, 2017 20:29
@fpagnoux fpagnoux mentioned this pull request May 23, 2017
Makefile Outdated
@@ -19,3 +19,4 @@ test: check-syntax-errors check-no-prints
@# Launch tests from openfisca_france/tests directory (and not .) because TaxBenefitSystem must be initialized
@# before parsing source files containing formulas.
nosetests tests --exe --with-doctest
openfisca-run-test -c openfisca_france --nose tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use long option for -c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@guillett
Copy link
Member

@fpagnoux, cette configuration CircleCI utilise 4 conteneurs pour un build. Une conséquence de cela, c'est qu'un seul build peut être lancé à la fois.

Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

circle.yml Outdated
parallel: true
files:
- tests/**/*.yaml
- tests/**/*.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a single glob: tests/**/*.ya?ml

Makefile Outdated
@@ -19,3 +19,4 @@ test: check-syntax-errors check-no-prints
@# Launch tests from openfisca_france/tests directory (and not .) because TaxBenefitSystem must be initialized
@# before parsing source files containing formulas.
nosetests tests --exe --with-doctest
openfisca-run-test -c openfisca_france --nose tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fpagnoux fpagnoux merged commit a30f611 into master May 31, 2017
@fpagnoux fpagnoux deleted the circle-parallel branch May 31, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants