Mets à jour l'API pour qu'elle soit compatible avec Core #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandcha
approved these changes
Jul 13, 2017
CHANGELOG.md
Outdated
| * Correction d'un crash | ||
| + Détails : | ||
| - Mets à jour la version d'OpenFisca-Web-API requise pour qu'elle soit compatible avec la version d'OpenFisca-Core requise. | ||
| - Les deux versions référencées dans le `setup.py` étaient incompatibles, rendant impossible, dans certaines conditions, le démarrage de l'API. |
There was a problem hiding this comment.
Si identifiées, préciser quelles sont ces certaines conditions posant problème ?
| def tearDown(self): | ||
| self.process.terminate() | ||
|
|
||
| def test_response(self): |
There was a problem hiding this comment.
👍
Attraper
ConnectionErrorpour lui adjoindre un message plus concis lorsque l'API n'est pas joignable ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyétaient incompatibles, rendant impossible, dans certaines conditions, le démarrage de l'API.