Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_input for remuneration fonctionnaire #925

Merged
merged 7 commits into from
Mar 16, 2018

Conversation

benjello
Copy link
Member

@benjello benjello commented Mar 8, 2018

  • Correction d'un bug
  • Zones impactées :
    • openfisca_france/model/revenus/activite/salarie.py
  • Détails :
    • Autorise le basculement automatique en mensuel de revenus annuels renseignés pour les fonctionnaires
    • Adopte un comportement similaire aux autres salariés

@benjello
Copy link
Member Author

Je mergerais bien cette PR rapidement car elle fait planter certains notebooks.
Merci !

@benjello
Copy link
Member Author

Et elle est inoffensive ;-)

Copy link
Contributor

@Anna-Livia Anna-Livia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourrais tu rajouter un test ? Sinon, c'est go pour moi

@benjello
Copy link
Member Author

benjello commented Mar 15, 2018

@Anna-Livia : je peux rajouter un test. J'ai hésité car on me dit que les tests prennent trop de temps.
Comment juger de l'opportunité d'un test ?

@benjello
Copy link
Member Author

@Anna-Livia : les test te conviennent-ils ?

@Anna-Livia Anna-Livia merged commit 61b3a25 into master Mar 16, 2018
@Anna-Livia Anna-Livia deleted the fix-set-input-fontionnaire branch March 16, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants