This repository has been archived by the owner on Apr 16, 2018. It is now read-only.
Adapt parsers to Openfisca 2.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2981,7 +2981,7 @@ def parse_value(self, node, container = None): | |||
| unicode(value).encode('utf-8')) | |||
| item_value = self.parse_value(dict_children[child_index + 2], container = container) | |||
| child_index += 3 | |||
| if dict_children[child_index].type == tokens.COMMA: | |||
| if (child_index < len(dict_children)) and dict_children[child_index].type == tokens.COMMA: | |||
There was a problem hiding this comment.
I don't know why this bug appeared now, but it was making the web-api tests to crash. I tried to understand the logic to fix it, but maybe I missed something so I could appreciate a review.
There was a problem hiding this comment.
No precise idea since it's really not my code and it's quite complicated.
I'm testing it (openfisca-core/france on master, web-api and parsers on remove-metaclasses).
cbenz
force-pushed
the
remove-metaclasses
branch
from
015b41c
to
0f30b9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply core API changes introduced by openfisca-core 2.0