-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3.7 #60
Conversation
P'tits soucis au ERROR: openfisca-survey-manager 0.38.0 has requirement numpy<1.16,>=1.11, but you'll have numpy 1.17.4 which is incompatible.
ERROR: flake8 3.6.0 has requirement pycodestyle<2.5.0,>=2.4.0, but you'll have pycodestyle 2.5.0 which is incompatible. |
The first problem is linked with openfisca/openfisca-survey-manager#79 |
J'obtiens cette erreur au ...
...openfisca-ceq/openfisca_ceq/tools/indirect_taxation/variables_generator.py", line 256, in generate_ad_valorem_tax_variables
functions_by_name[func.__name__] = func
UnboundLocalError: local variable 'func' referenced before assignment Il me semble qu'il manque quelques étapes de configuration pour l'exécution qui seront probablement aussi nécessaires à CircleCI.
[ceq]
consumption_items_directory = .../ceq_consumption_items_directory
mais aucune valeur. @benjello Obtiens-tu la même erreur en local ?
|
openfisca_senegal/__init__.py
Outdated
@@ -3,7 +3,7 @@ | |||
import os | |||
|
|||
from openfisca_core.taxbenefitsystems import TaxBenefitSystem | |||
|
|||
from openfisca_ceq.tests.test_indirect_tax_variables_generator import add_coicop_item_to_tax_benefit_system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendre cette dépendance à CEQ conditionnelle à un élément de configuration ?
Ici, on rend la dépendance obligatoire alors que nous avons un usage autre initié à l'OGP. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'arrive pas à rendre le truc optionnel et propre ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et, si on conserve une dépendance à CEQ au chargement du modèle, s'assurer qu'il ne s'agisse pas d'un module
tests
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dispo pour aider là-dessus quand on aura des tests qui passent 🙂
Désolé @sandcha , il manque encore un fichier qui n'est pas complètement nettoyé. |
[ ] Documentez votre contribution avec des références législatives.[ ] Mettez à jour ou ajoutez des tests correspondant à votre contribution.setup.py
.CHANGELOG.md
.