Apply ColorTransform directly when rendering text and shapes #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some ColorTransforms to my little test program here Before this patch, the ColorTransforms change nothing on targets other than Flash: HTML5: Flash: |
vizanto
added a commit
to vizanto/openfl-linestyle-bug
that referenced
this pull request
Aug 22, 2016
|
I just discovered that changing the Edit: fixed |
Closed
vizanto
force-pushed
the
develop
branch
2 times, most recently
from
7cf7ee4
to
d3afc19
Compare
This patch refactors and de-duplicates code in the Cairo and Canvas rendering classes and implements the application of color transforms to TextFields and (Shape) Graphics. It introduces 2 new macros to ColorTransform that help calculate the RGBA values without temporary allocations. If and when Haxe supports multiple inline return values, these could be rewritten. Drawing Bitmaps with ColorTransform is untested and not implemented by this patch.
|
Discovered a copy-pasta error in |
…on uses for these unique events)" This reverts commit c0511ab.
…for these unique events)
|
Reopened as #1251 because I keep pushing to this branch :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors and de-duplicates code in the Cairo and Canvas rendering classes and implements the application of color transforms to TextFields and (Shape) Graphics.
Luckily worldColorTransform was already implemented so it turned out to be fairly straightforward :-)
It introduces 2 new macros to ColorTransform that help calculate the RGBA values without temporary allocations. If and when Haxe supports multiple inline return values, these could be rewritten. Hopefully you'll find these readable enough... :)
Drawing Bitmaps with ColorTransform is untested and not implemented by this patch.