refactor MovieClip to fix several bugs #1607
Conversation
| @@ -47,7 +47,7 @@ class MovieClip extends flash.display.MovieClip { | |||
| @:noCompletion private var activeObjects:Array<ChildObject>; | |||
|
|
|||
| #if flash | |||
| @:noCompletion private var __currentFrame:Int; | |||
| @:noCompletion private var __currentFrameOneIndexed:Int; | |||
There was a problem hiding this comment.
👷 🚧 WARNING: I do not feel I understand the tools version of the MovieClip class, and while these changes seem to satisfy the build, you should really check them to be sure the original intent is still functional. With or without them, I couldn't tell the difference.
It would help to get an explanation from you @jgranick here.
openfl/display/MovieClip.hx
Outdated
| if (null != duplicate) { | ||
|
|
||
| trace("Multiple CREATE tags for the same characterId and depth are being merged.\n" | ||
| + "Asset \""+ untyped this.__swf.library.rootPath +"\", " |
There was a problem hiding this comment.
this trace statement should be removed once done debugging
openfl/display/MovieClip.hx
Outdated
|
|
||
| if (null == symbol) { | ||
|
|
||
| trace("Unable to CREATE DisplayObject instance; got NULL symbol\n" |
There was a problem hiding this comment.
once we figure out why null symbols exist (you may already know, i haven't had time to figure out yet), we should remove this unless/except debugging.
openfl/display/MovieClip.hx
Outdated
| // TODO: find out why some displayObject instances are null | ||
| if (null == displayObject) { | ||
|
|
||
| trace("Unable to CREATE DisplayObject instance; got NULL __createObject()\n" |
openfl/display/MovieClip.hx
Outdated
| displayObjectCache = frameObjectEntry.displayObjectCache; | ||
| } | ||
| if (null == displayObjectCache || null == displayObjectCache.displayObject) { | ||
| trace("Tried to UPDATE a DisplayObject child that hasn't been CREATED yet. " |
There was a problem hiding this comment.
this may benefit from an #if debug block
|
rebasing this one now |
several bugs related to zero/one-indexed frames, and synchronizing frame playback
Refactor
MovieClip.__enterFrame()and friends to fix:FrameObjectCREATEduplicationFrameObjectREMOVEfailures,Added a ton of comments to improve maintainability.
Tried to code in a way that made it more obvious what was happening, with only mild performance optimizations in mind. Should be as-fast or faster than before.
The only major change is that all
MovieClip.__children:DisplayObjectinstances are initialized fromMovieClip.new()constructor now. This happens once instead of multiple times throughout animation loop/playback. We believe its a sensible approach inspired by other implementations, and a performance optimization (read comments in patch for detail).The primary reason we needed this was to eliminate several bugs that were breaking playback for a very complex set of
.SWFfiles we had imported usingSWFLiteExporterand were playing back at runtime in the browser with OpenFL on the HTML5 target.There are still issues to be resolved with the Filters and Blend Modes, but we'll get to those soon.
💪 credit @sbimikesmullin with minor contributions from Elvir Tatarevic and @sbijoshj.
💡 Interested in whatever feedback good/bad you have on this one @jgranick. Could go over it in detail on call if you want, and show before/after behavior.
🛑 ✋ 👮 WARNING: This PR depends on #1599 and #1601, as written. You should merge those first. They may cause this one to conflict but shouldn't because they have the exact same lines.