-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JSON (de)serialization performance with go-json #559
Conversation
Before
After
|
@foxdalas thanks for contribution. It seems some integration tests are still failing, would you mind checking those? |
Yes, I will |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 81.07% 81.18% +0.11%
==========================================
Files 28 28
Lines 2256 2270 +14
==========================================
+ Hits 1829 1843 +14
Misses 337 337
Partials 90 90 ☔ View full report in Codecov by Sentry. |
@foxdalas thanks for the contribution!
I'm wondering, would you be able to deploy this branch to your instance and share some performance gains? I think those are not so easy to see in the local tests here. |
I have planned test to tomorrow. I will back day after tomorrow |
@marceloboeira The same environment, configuration and requests rate. total profit ~25% ![]() ![]() ![]() ![]() |
@foxdalas awesome! |
Description
More effective JSON serialization and deserialization.
Motivation and Context
We have more than 20k RPS on our Flagr installation, and we are trying to find a way to improve performance.
How Has This Been Tested?
Types of changes
Checklist: