Improve JSON (de)serialization performance with go-json

[foxdalas]

Description

More effective JSON serialization and deserialization.

Motivation and Context

We have more than 20k RPS on our Flagr installation, and we are trying to find a way to improve performance.

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[ghost]

👇 Click on the image for a new way to code review

Legend

[foxdalas]

Before

BenchmarkEvalFlag-12               71962             17172 ns/op            1720 B/op         32 allocs/op
BenchmarkEvalFlagsByTags-12        74755             16713 ns/op            1946 B/op         36 allocs/op

After

BenchmarkEvalFlag-12               72667             17019 ns/op            1721 B/op         32 allocs/op
BenchmarkEvalFlagsByTags-12        74432             16545 ns/op            1945 B/op         36 allocs/op

[marceloboeira]

@foxdalas thanks for contribution. It seems some integration tests are still failing, would you mind checking those?

[foxdalas]

@foxdalas thanks for contribution. It seems some integration tests are still failing, would you make checking those?

Yes, I will

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fcc74ae) 81.07% compared to head (a13e105) 81.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   81.07%   81.18%   +0.11%     
==========================================
  Files          28       28              
  Lines        2256     2270      +14     
==========================================
+ Hits         1829     1843      +14     
  Misses        337      337              
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marceloboeira]

@foxdalas thanks for the contribution!

We have more than 20k RPS on our Flagr installation, and we are trying to find a way to improve performance.

I'm wondering, would you be able to deploy this branch to your instance and share some performance gains? I think those are not so easy to see in the local tests here.

[foxdalas]

@foxdalas thanks for the contribution!

We have more than 20k RPS on our Flagr installation, and we are trying to find a way to improve performance.

I'm wondering, would you be able to deploy this branch to your instance and share some performance gains? I think those are not so easy to see in the local tests here.

I have planned test to tomorrow. I will back day after tomorrow

[foxdalas]

@marceloboeira The same environment, configuration and requests rate.

total profit ~25%

[marceloboeira]

@foxdalas awesome!