feat: new ordering choice by price (lowest first) #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dq18
approved these changes
Mar 6, 2024
src/constants.js
Outdated
| @@ -20,8 +20,9 @@ export default { | |||
| { key: '-price_count', value: 'Number of prices', icon: 'mdi-tag-multiple-outline' }, | |||
| ], | |||
| PRICE_ORDER_BY_LIST: [ | |||
| { key: '-created', value: 'Addition date', icon: 'mdi-clock-outline' }, | |||
| { key: 'price', value: 'Price (cheapest first)', icon: 'mdi-currency-eur' }, | |||
There was a problem hiding this comment.
I would put "Price: ascending order" as I have seen on several marketplace.
Also, would put another icon, as euro is not relevant outside EU. Maybe order-numeric-ascending, since I'm sure the descending option will come soon :)
There was a problem hiding this comment.
any screenshots for the wording ? ascending is too technical i think
| Image | |
|---|---|
| Vinted |  |
| Amazon |  |
| Ebay |  |
| Etsy |  |
There was a problem hiding this comment.
I'll change to just "Price", and we can open an issue to figure out the best wording :)
There was a problem hiding this comment.
Hmm true, my bad. I rarely go to marketplaces and when I do they are in German with autotranslation to English. In German it is "Aufsteigend" and "Absteigend" which translates to "Ascending" and "Descending"
raphodn
changed the title
raphodn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the pages with a list of prices, add a new ordering by "cheapest first"
Screenshot