-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new ordering choice by price (lowest first) #408
Conversation
src/constants.js
Outdated
@@ -20,8 +20,9 @@ export default { | |||
{ key: '-price_count', value: 'Number of prices', icon: 'mdi-tag-multiple-outline' }, | |||
], | |||
PRICE_ORDER_BY_LIST: [ | |||
{ key: '-created', value: 'Addition date', icon: 'mdi-clock-outline' }, | |||
{ key: 'price', value: 'Price (cheapest first)', icon: 'mdi-currency-eur' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put "Price: ascending order" as I have seen on several marketplace.
Also, would put another icon, as euro is not relevant outside EU. Maybe order-numeric-ascending
, since I'm sure the descending option will come soon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea for the icon 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change to just "Price", and we can open an issue to figure out the best wording :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm true, my bad. I rarely go to marketplaces and when I do they are in German with autotranslation to English. In German it is "Aufsteigend" and "Absteigend" which translates to "Ascending" and "Descending"
What
In the pages with a list of prices, add a new ordering by "cheapest first"
Screenshot