Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additives explorer #2116

Merged
merged 16 commits into from
Jan 29, 2019
Merged

Additives explorer #2116

merged 16 commits into from
Jan 29, 2019

Conversation

PrajwalM2212
Copy link
Member

@PrajwalM2212 PrajwalM2212 commented Jan 18, 2019

# Conflicts:
#	app/src/main/AndroidManifest.xml
#	app/src/main/java/openfoodfacts/github/scrachx/openfood/utils/NavigationDrawerListener.java
#	app/src/main/res/values/strings.xml
@PrajwalM2212 PrajwalM2212 added the additives Issues relating to the use of additives in the applicatoin label Jan 18, 2019
@teolemon
Copy link
Member

:app:compileObfDebugJavaWithJavac/home/travis/build/openfoodfacts/openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/AdditivesExplorer.java:37: error: AdditivesExplorer is not abstract and does not override abstract method onClick(int,String) in ClickListener
public class AdditivesExplorer extends BaseActivity implements AdditivesAdapter.ClickListener {
       ^
/home/travis/build/openfoodfacts/openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/AdditivesExplorer.java:100: error: method does not override or implement a method from a supertype
    @Override
    ^
/home/travis/build/openfoodfacts/openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/utils/WifiUploadReceiver.java:96: error: cannot find symbol
            String contentText = this.getResources().getQuantityString(R.plurals.offline_notification_count, listSaveProduct.size(), listSaveProduct.size());
                                                                                ^
  symbol:   variable offline_notification_count
  location: class plurals
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/travis/build/openfoodfacts/openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/views/MainActivity.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors
 FAILED
FAILURE: Build failed with an exception.

@teolemon
Copy link
Member

Thanks @ripetrescu for the review :-)
Merging @PrajwalM2212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
additives Issues relating to the use of additives in the applicatoin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants