Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Harcoded search category hint #4539

Merged
merged 1 commit into from Mar 19, 2022
Merged

fix: Harcoded search category hint #4539

merged 1 commit into from Mar 19, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 19, 2022

Fix for "search for a food category" text being hardcoded in the app.
Will partially resolve #4535

@g123k g123k requested a review from a team as a code owner March 19, 2022 11:50
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

teolemon
teolemon approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@teolemon teolemon added translations Issues related to translation of applications i18n Translations labels Mar 19, 2022
VaiTon
VaiTon approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@VaiTon VaiTon merged commit 5050cf1 into openfoodfacts:develop Mar 19, 2022
@github-actions github-actions bot mentioned this pull request Mar 19, 2022
Merged
g123k added a commit to g123k/openfoodfacts-androidapp that referenced this pull request Mar 19, 2022
@g123k
fix: "Search for a food category" hint hardcoded (openfoodfacts#4539)
3fbbdc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

@VaiTon VaiTon VaiTon approved these changes

Assignees
No one assigned
Labels
i18n Translations translations Issues related to translation of applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French translation issues
3 participants
@g123k @teolemon @VaiTon