Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Harcoded search category hint #4539

Merged
merged 1 commit into from
Mar 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ class CategoryListFragment : BaseFragment() {
val searchMenuItem = menu.findItem(R.id.action_search)
val searchView = searchMenuItem.actionView as SearchView

// TODO: 26/07/2020 use resources
searchView.queryHint = "Search for a food category"
searchView.queryHint = getString(R.string.hint_category_list)

if (searchManager.getSearchableInfo(requireActivity().componentName) == null) return

Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values-fr-rFR/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -762,4 +762,5 @@
<string name="msg_welcome_ecoscore">Une synthèse de l\'impact environnemental de votre alimentation.</string>
<string name="title_welcome_matomo">Partager anonymement les statistiques</string>
<string name="msg_welcome_matomo">Aidez les bénévoles d\'Open Food Facts à améliorer l\'application. Vous décidez si vous envoyez des analyses anonymes.\n\nSi vous changez d\'avis, cette option peut être activée et désactivée à tout moment à partir des paramètres.</string>
<string name="hint_category_list">Recherche une catégorie</string>
</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -766,4 +766,5 @@
<string name="night">Nuit</string>
<string name="required_for_ecoscore">(Requis pour calculer l\'Eco-Score)</string>
<string name="hint_origin">Exemples: USA, France, Italie</string>
<string name="hint_category_list">Recherche une catégorie</string>
</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -896,4 +896,5 @@

<string name="title_welcome_matomo">Send anonymous analytics</string>
<string name="msg_welcome_matomo">Help the Open Food Facts volunteers to improve the app. You decide if you send anonymous analytics.\n\nIf you change your mind this option can be enabled and disabled at any time from the settings.</string>
<string name="hint_category_list">Search for a food category</string>
</resources>