Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_7/#90 - fixed alcohol tags; added enough comments for pub.dev #211

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • api_getProduct_test.dart: added a test about the fix on alcohol
  • LanguageHelper.dart: commented individually each language
  • Nutriments.dart: fixed alcohol tags; commented individually each field
  • Nutriments.g.dart: (generated) fixed alcohol tags

…r pub.dev

Impacted files:
* `api_getProduct_test.dart`: added a test about the fix on alcohol
* `LanguageHelper.dart`: commented individually each language
* `Nutriments.dart`: fixed alcohol tags; commented individually each field
* `Nutriments.g.dart`: (generated) fixed alcohol tags
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki, hopefully it will bring us to 130 points

@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your code review!
Even if it doesn't bring us to 130 points (but it will!), at least I could find and fix a bug on alcohol.

@teolemon
Copy link
Member

teolemon commented Aug 2, 2021

@monsieurtanuki mentions his daily alcohol fix 😁
more seriously, small merge conflict to solve

@monsieurtanuki monsieurtanuki merged commit f5cd0ab into openfoodfacts:master Aug 3, 2021
@monsieurtanuki monsieurtanuki deleted the fix_7/#90 branch September 17, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants