[Up for adoption] Bumping xcode to make the build work again #904
Conversation
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: #707
This snapshot is not workable, I just want to preserve an idea which probably won't work, which is passing a closure to AttributeTableViewCell to launch the floatingPanel. However, I made FormTableViewController the owner of the floating panel and that is not allowed. So now I am switching to a new strategy to make a delegate for AttributeTableViewCell and designate the ProductDetailTableViewController as the delegate and as the floating panel host as I originally intended.
Created delegate protocol for AttributeTableViewCell to call back to ProductDetailViewController so it can launch the FloatingPanelVC Extend ProductDetailVC so it can handle FloatingPanels similar to ScannerViewController. Create ProductAttributeViewController.swift and .storyboard to be the FloatingPanels VC and view to hold AttributeView Resolves: #707
Add the frame of the image to the exclusion path of the text view. Create func getIconAspectConstraint() to get the dynamic aspect ratio of the image in code so we can dynamically adjust the imageView height and width. Place image related code in completion handle of KingFisher setImage(with: resource) to ensure the adjustments are attempted after the image is retrieved. Resolves: #707
…n SVG's HTML to get dimensions
|
fatal error: /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: /Users/runner/Library/Caches/org.carthage.CarthageKit/DerivedData/12.4_12D4e/Alamofire/4.8.2/Build/Intermediates.noindex/ArchiveIntermediates/Alamofire iOS/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/Alamofire.framework/Alamofire and /Users/runner/Library/Caches/org.carthage.CarthageKit/DerivedData/12.4_12D4e/Alamofire/4.8.2/Build/Products/Release-iphonesimulator/Alamofire.framework/Alamofire have the same architectures (arm64) and can't be in the same fat output file Building universal frameworks with common architectures is not possible. The device and simulator slices for "Alamofire" both build for: arm64 |
teolemon
changed the title
teolemon
changed the title
|
I think I can fix this. |
|
@slava-sh If the build passes, this branch will trigger automatically a Testflight |
* Update dependencies * Update project.yml to use XCFrameworks * Extract scripts/carthage.sh * Make scripts/setup.sh work when $CI is not set
> 11.7.0") TO xcversion(version: "> 12.0")This PR needs adoption 🐣