Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update API paths #96

Merged
merged 3 commits into from
May 30, 2024
Merged

fix: Update API paths #96

merged 3 commits into from
May 30, 2024

Conversation

shivneelmistry
Copy link
Contributor

What

  • API paths were outdated causing the gem to fail
  • Some inconsistencies in logic

Fixes bug(s)

  • Upgraded from V0 to V2 for product api
  • Updated tocgi/countries.pl such that locale logic works
  • Removed method that wasn't consumed

Next Step(s)

  • Ensure there is logic handling errors
  • Later an upgrade from V2 to V3 will be needed
  • 2/36 tests are skipped, need to verify if these are required

@shivneelmistry shivneelmistry requested a review from a team as a code owner May 30, 2024 06:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shivneelmistry shivneelmistry changed the title Update gem fix: Update API paths May 30, 2024
@shivneelmistry shivneelmistry mentioned this pull request May 30, 2024
Open
@teolemon teolemon merged commit d383f5b into openfoodfacts:main May 30, 2024
4 of 9 checks passed
@teolemon
Copy link
Member

Congratulations on your first PR @shivneelmistry 🎉
thanks @nicolasleger

@shivneelmistry shivneelmistry deleted the update_gem branch May 31, 2024 01:24
@SofiBit
Copy link

SofiBit commented Oct 11, 2024

@nicolasleger @teolemon Hey! These changes was published? I can't get product because url isn't correct. I would appreciate any answers thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasleger nicolasleger nicolasleger approved these changes

Assignees

@shivneelmistry shivneelmistry

Labels
None yet
Projects
🍊 Open Food Facts Ruby SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivneelmistry @teolemon @SofiBit @nicolasleger