fix: always display contribution panel after edit (#8745)

openfoodfacts · Jul 28, 2023 · 35a1666 · 35a1666
1 parent c7f1616
commit 35a1666
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -285,7 +285,7 @@ stop_tests:
 clean_tests:
 	${DOCKER_COMPOSE_TEST} down -v --remove-orphans
 
-update_tests_results:
+update_tests_results: build_lang_test
 	@echo "🥫 Updated expected test results with actuals for easy Git diff"
 	${DOCKER_COMPOSE_TEST} up -d memcached postgres mongodb backend dynamicfront incron
 	${DOCKER_COMPOSE_TEST} run --no-deps --rm -e GITHUB_TOKEN=${GITHUB_TOKEN} backend /opt/product-opener/scripts/build_tags_taxonomy.pl ${name}

diff --git a/cgi/product_multilingual.pl b/cgi/product_multilingual.pl
@@ -1578,10 +1578,8 @@ ($product_ref, $field, $language)
 		initialize_knowledge_panels_options($knowledge_panels_options_ref, $request_ref);
 		$knowledge_panels_options_ref->{knowledge_panels_client} = "web";
 		create_contribution_card_panel($product_ref, $lc, $cc, $knowledge_panels_options_ref);
-		if (defined $product_ref->{"knowledge_panels_" . $lc}{data_quality_errors}) {
-			$template_data_ref_process->{contribution_card_panel}
-				= display_knowledge_panel($product_ref, $product_ref->{"knowledge_panels_" . $lc}, "contribution_card");
-		}
+		$template_data_ref_process->{contribution_card_panel}
+			= display_knowledge_panel($product_ref, $product_ref->{"knowledge_panels_" . $lc}, "contribution_card");
 	}
 	$template_data_ref_process->{code} = $product_ref->{code};
 	process_template('web/pages/product_edit/product_edit_form_process.tt.html', $template_data_ref_process, \$html)