Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code crash for EMB suggestions #10049

Closed
monsieurtanuki opened this issue Mar 29, 2024 · 2 comments · Fixed by #10113 or #10123
Closed

Code crash for EMB suggestions #10049

monsieurtanuki opened this issue Mar 29, 2024 · 2 comments · Fixed by #10113 or #10123
Assignees
@stephanegigandet
Labels
🐛 bug This is a bug, not a feature request. ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🎯 P0

Comments

@monsieurtanuki
Copy link
Contributor

What

  • The problem started a few days ago, perhaps from @damil's bf084bb?
  • Don't know if it's a problem of data (not supposed to have quotes in the results), code or settings.

Steps to reproduce the behavior

https://world.openfoodfacts.org/api/v3/taxonomy_suggestions?tagtype=emb_codes&lc=fr&string=fR&limit=25

Software error:
Can't use string ("FR 01.004.002 EC") as a HASH ref while "strict refs" in use at /srv/off/lib/ProductOpener/APITaxonomySuggestions.pm line 133.
For help, please send mail to the webmaster ([contact@openfoodfacts.org](mailto:contact@openfoodfacts.org)), giving this error message and the time and date of the error.
@teolemon teolemon added ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🐛 bug This is a bug, not a feature request. 🎯 P0 labels Mar 29, 2024
@hangy
Copy link
Member

hangy commented Mar 29, 2024

Not bf084bb. I can also reproduce the bug in the parent commit 0627780.

@monsieurtanuki monsieurtanuki mentioned this issue Apr 7, 2024
Merged
@stephanegigandet
Copy link
Contributor

The bug was probably introduced by https://github.com/openfoodfacts/openfoodfacts-server/pull/9395/files , I will fix it

@stephanegigandet stephanegigandet self-assigned this Apr 9, 2024
@stephanegigandet stephanegigandet mentioned this issue Apr 9, 2024
Merged
alexgarel pushed a commit that referenced this issue Apr 15, 2024
@stephanegigandet
fix: suggestions for packaging codes / EMB codes (#10113)
0503521 
fixes #10049
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Apr 15, 2024
Merged
john-gom pushed a commit that referenced this issue May 24, 2024
@stephanegigandet @john-gom
fix: suggestions for packaging codes / EMB codes (#10113)
c7a9fd1 
fixes #10049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
🐛 bug This is a bug, not a feature request. ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii 🎯 P0
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
4 participants
@hangy @teolemon @stephanegigandet @monsieurtanuki