fix: some translations moved from .po files to Config.pm #10294
Conversation
github-actions
bot
added
API
| @@ -1322,7 +1322,7 @@ | |||
| { | |||
| "element_type" : "text", | |||
| "text_element" : { | |||
| "html" : "\n If the information does not match the information on the packaging, please complete or correct it.\n Open Food Facts is a collaborative database, and every contribution is useful for all.\n " | |||
| "html" : "\n Si les informations ne correspondent pas à celles figurant sur l'emballage, vous pouvez les compléter ou les corriger. Merci!\n Open Food Facts est une base de données collaborative, et chaque contribution est utile pour tous.\n " | |||
There was a problem hiding this comment.
Not sure I understand why these expected results are changing to French. Did you maybe set a language code to test something else and forget to set it back when you re-created the test results?
There was a problem hiding this comment.
@john-gom Good catch. For some reason the translation PR #10125 removed some new English translations in po/common/en.po : https://github.com/openfoodfacts/openfoodfacts-server/pull/10125/files#diff-5bbd72255d2cf6bb1099c86f8cbb873e9007d13e3357d1b43908f1b97c880c03 cc @teolemon
There was a problem hiding this comment.
I added the missing English translations in Crowdin, and I will add them back manually in en.po
There was a problem hiding this comment.
beware about duplicated strings.
|
Some translations (that were not really translation but more configuration) were moved from .po files to Config_*.pm
Unfortunately one of the translations removed from .po file "site_name" was the one used to compute the structure that maps country codes to languages, which meant that requests on the fr. subdomain didn't get the French language, and it broke quite a few things downstream.
The tests were passing before the last Crowdin PR as I removed the strings from common.pot but not from all the .po files.
Also a few issues related to some of the other moved translations.