Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Wikidata items to categories #5805

Merged
merged 4 commits into from
Jan 5, 2022
Merged

feat: Add Wikidata items to categories #5805

merged 4 commits into from
Jan 5, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Oct 2, 2021 •
edited
Loading

What

  • Add Wikidata items to categories
  • Misc fixes
  • One commented out knowledge experiment on a category

@teolemon teolemon changed the title Add Wikidata items to categories chore: Add Wikidata items to categories Oct 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon added the WikiData We link taxonomies to Wikidata (& back) - https://wiki.openfoodfacts.org/Structured_Data/Wikidata label Jan 5, 2022
@teolemon teolemon requested a review from a team January 5, 2022 10:45
@teolemon teolemon changed the title chore: Add Wikidata items to categories feat: Add Wikidata items to categories Jan 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

teolemon
teolemon commented Jan 5, 2022
View reviewed changes
taxonomies/categories.txt
Comment on lines +57197 to +57199
compulsory_ingredient:fr:graines de moutarde
minimum_percentage:fr:vin blanc aligoté:25
minimum_percentage:fr:chardonnay:25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compulsory_ingredient:fr:graines de moutarde
minimum_percentage:fr:vin blanc aligoté:25
minimum_percentage:fr:chardonnay:25
# compulsory_ingredient:fr:graines de moutarde
# minimum_percentage:fr:vin blanc aligoté:25
# minimum_percentage:fr:chardonnay:25

@teolemon teolemon merged commit d71eee3 into main Jan 5, 2022
@teolemon teolemon deleted the taxotac branch January 5, 2022 20:20
@github-actions github-actions bot mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleene aleene aleene approved these changes

Assignees
No one assigned
Labels
categories WikiData We link taxonomies to Wikidata (& back) - https://wiki.openfoodfacts.org/Structured_Data/Wikidata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teolemon @aleene