Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Import serving size bug #6474

Merged
merged 5 commits into from
Mar 9, 2022
Merged

fix: Import serving size bug #6474

merged 5 commits into from
Mar 9, 2022

Conversation

stephanegigandet
Copy link
Contributor

fixes #6473 , adds a test

@stephanegigandet stephanegigandet requested a review from a team as a code owner March 9, 2022 11:09
@stephanegigandet stephanegigandet changed the title Import serving size bug fix: Import serving size bug Mar 9, 2022
@github-actions github-actions bot added Data import export 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests labels Mar 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit ee2ee44 into main Mar 9, 2022
@alexgarel alexgarel deleted the import-serving-size-bug branch March 9, 2022 15:30
@github-actions github-actions bot mentioned this pull request Mar 9, 2022
Merged
@teolemon teolemon added this to the V1.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Data import export 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging this pull request may close these issues.

Import of nutrition data specified for a serving size fail, and set the serving size to "serving"
3 participants
@stephanegigandet @alexgarel @teolemon