feat: reset preferences instead of deleting + add switch to use preferences in preferences + fix bug for unknown mandatory attributes #6800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephanegigandet
commented
May 19, 2022
•
stephanegigandet
commented
- delete preferences button changed to reset preferences button + a precision that it will be Nutri-Score, Eco-Score, NOVA
- in the preferences selection, add a switch at the top to use the preferences for matching products
- if a mandatory attribute is unknown, the product status is set to unknown (bug identified by @monsieurtanuki in Implement new algorithm to compute how products match users food preferences -- being tested on OFF website smooth-app#1894 (comment) )
github-actions
bot
added
the
Translations
teolemon
reviewed
May 19, 2022
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
…s-server into product-match
stephanegigandet
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
added
the
personal search
alexgarel
approved these changes
May 24, 2022
| var html = '<fieldset class="switch round success" tabindex="0" id="' + checkbox_id +'_switch" style="float:left;margin:0;margin-right:.5rem;padding-top:0.1rem;">' | ||
| + '<input class="preferences_checkboxes" id="' + checkbox_id + '" type="checkbox"' + checked + '>' | ||
| + '<label for="' + checkbox_id +'"></label></fieldset>' | ||
| + '<label for="' + checkbox_id +'" style="float:left;margin-right:1em;padding-top:4px">' + preferences_text + '</label>'; |
There was a problem hiding this comment.
One day you will embrace javascript template strings :-P
There was a problem hiding this comment.
I'll do it in another PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.