fix: use normalized ids for untaxonomized ingredients and specific ingredients #7131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
approved these changes
Jul 25, 2022
|
|
||
| # Integration tests | ||
|
|
||
| perl integration/import_csv_file.t --update-expected-results |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ingredients structure of a product, there is an "id" field, which contains the canonical id of the ingredient. But if the ingredient does not exist in the taxonomy, it was prefixed with the language code but not normalized. So we had entries like "fr:Un ingrédient pas reconnu".
This changes it to a normalized string: "fr:un-ingredient-pas-reconnu".
A result is that is easier to match specific ingredients that are not in the taxonomy: fixes #7063