Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect for links sent via app share feature are broken #7161

Closed
KommX opened this issue Aug 1, 2022 · 1 comment · Fixed by #7164
Closed

Redirect for links sent via app share feature are broken #7161

KommX opened this issue Aug 1, 2022 · 1 comment · Fixed by #7164
Labels
🐛 bug This is a bug, not a feature request.

Comments

@KommX
Copy link
Contributor

KommX commented Aug 1, 2022

Describe the bug

When I share a link from the app, this link will be redirected via HTTP 302 to a broken URL. I file this bug report here, because I think, that the redirect is the bug here and not the URL generated by the mobile app.

To Reproduce

  1. Share a product link from the app. (e.g. https://de-de.openfoodfacts.org/product/4005514040975?app_name=Smoothie+-+OpenFoodFacts&app_version=3.5.1%2B693&app_uuid=d1445660a73e40bd&app_platform=ios%2BVersion+15.6+%28Build+19G71%29&comment).
  2. Go to this URL via desktop browser.

Expected behavior

I expect that I end up on the product page.

Screenshots

No response

Additional context

The redirect is returning a malformed URL with the tld '.orgproduct'.

curl 'https://de-de.openfoodfacts.org/product/4005514040975?app_name=Smoothie+-+OpenFoodFacts&app_version=3.5.1%2B693&app_uuid=d1445660a73e40bd&app_platform=ios%2BVersion+15.6+%28Build+19G71%29&comment'

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>302 Found</title>
</head><body>
<h1>Found</h1>
<p>The document has moved <a href="https://de.openfoodfacts.orgproduct/4005514040975?app_name=Smoothie+-+OpenFoodFacts&amp;app_version=3.5.1%2B693&amp;app_uuid=d1445660a73e40bd&amp;app_platform=ios%2BVersion+15.6+%28Build+19G71%29&amp;comment">here</a>.</p>
<hr>
<address>Apache/2.4.25 (Debian) Server at de-de.openfoodfacts.org Port 80</address>
</body></html>

Type of device

Browser

Browser version

Firefox 103.0

Number of products impacted

No response

Time per product

No response
@KommX KommX added the 🐛 bug This is a bug, not a feature request. label Aug 1, 2022
stephanegigandet added a commit that referenced this issue Aug 1, 2022
@stephanegigandet
fixes pb with initial slash in query string of redirects #7161
5787440
@stephanegigandet stephanegigandet mentioned this issue Aug 1, 2022
Merged
@stephanegigandet
Copy link
Contributor

Fixed, thanks for the report.

alexgarel pushed a commit that referenced this issue Aug 22, 2022
@stephanegigandet @alexgarel
fixes pb with initial slash in query string of redirects #7161
4c8e286
alexgarel pushed a commit that referenced this issue Aug 22, 2022
@stephanegigandet
fix: pb with initial slash in query string of redirects (#7164)
8902cb4 
* fixes  #7161
LandonPattison pushed a commit that referenced this issue Aug 27, 2022
@stephanegigandet @LandonPattison
fix: pb with initial slash in query string of redirects (#7164)
cb1a230 
* fixes  #7161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug This is a bug, not a feature request.
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pb with initial slash in query string of redirects openfoodfacts/openfoodfacts-server
2 participants
@KommX @stephanegigandet