Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pb with initial slash in query string of redirects #7164

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Conversation

stephanegigandet
Copy link
Contributor

fixes #7161

There's something different between docker and production:

in Docker, the QUERY_STRING environment variable is prefixed by / , but not in production. This caused issues with redirect URLs reconstructed with the query string.

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 8902cb4 into main Aug 22, 2022
@alexgarel alexgarel deleted the fix-redirects2 branch August 22, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect for links sent via app share feature are broken
2 participants