Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode not displayed for products with fake barcodes attributed by OFF, breaks Folksonomy Engine #7267

Closed
Tracked by #7525
CharlesNepote opened this issue Aug 29, 2022 · 5 comments · Fixed by #10223 or #10123
Labels
🐛 bug This is a bug, not a feature request. 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented Aug 29, 2022

What

To Reproduce

Part of

  • Folksonomy Engine
@CharlesNepote CharlesNepote added the 🐛 bug This is a bug, not a feature request. label Aug 29, 2022
@stephanegigandet stephanegigandet changed the title Barcode not displayed Barcode not displayed for products with fake barcodes attributed by OFF, breaks Folksonomy Engine Aug 30, 2022
@stephanegigandet
Copy link
Contributor

The product does not have a real barcode, so we don't display it. We could have a hidden .

@teolemon teolemon added Product Page 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. labels Oct 12, 2022
@teolemon teolemon added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Oct 31, 2022
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 2, 2024
@teolemon
Copy link
Member

teolemon commented May 3, 2024

The solution is either:

  • to handle Folksonomy Engine server side
  • to change the way the FE JS scripts gets the barcode (hidden in the DOM, or from the URL ?)

@alexgarel
Copy link
Member

The way to go IMO is to always have barcode but with display none (and no schema if it's fake)

@teolemon
Copy link
Member

teolemon commented May 3, 2024

I have added the number (200k) of impacted products to the GH project: https://world.openfoodfacts.org/code/2xxxxxxxxxxxx

alexgarel added a commit that referenced this issue May 3, 2024
hidden, for folksonomy engine to work.
fixes: #7267
alexgarel added a commit that referenced this issue May 6, 2024
hidden, for folksonomy engine to work.

fixes: #7267
john-gom pushed a commit that referenced this issue May 10, 2024
hidden, for folksonomy engine to work.

fixes: #7267
john-gom pushed a commit that referenced this issue May 24, 2024
hidden, for folksonomy engine to work.

fixes: #7267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🏷️ Folksonomy Project The Folksonomy project allows to add custom data to product, and model non food products. Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
Status: Done
4 participants