Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small changes in product files sent by Carrefour #7376

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

stephanegigandet
Copy link
Contributor

  • XML files are in UTF16 instead of UTF8
  • *_valNut.xml files renamed to *_valnut.xml

Added some tests to check that we accept both the old and new formats / names.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit 7ffef9f into main Sep 26, 2022
@alexgarel alexgarel deleted the carrefour branch September 26, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants