Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Fi and de ingredients #7441

Merged
merged 2 commits into from
Oct 6, 2022
Merged

taxonomy: Fi and de ingredients #7441

merged 2 commits into from
Oct 6, 2022

Conversation

moon-rabbitOFF
Copy link
Contributor

No description provided.

@moon-rabbitOFF moon-rabbitOFF added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Oct 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aleene
Copy link
Contributor

aleene commented Oct 5, 2022

This should not be necessary as the entries are already covered by xx:

@stephanegigandet stephanegigandet changed the title Fi and de ingredients taxonomy: Fi and de ingredients Oct 5, 2022
@@ -1153,6 +1153,7 @@ ar:عصية لبنية حمضية
bg:Lactobacillus acidophilus, L. acidophilus
xx:Lactobacillus acidophilus, L. acidophilus
fa:لاکنوباسیلوس اسیدوفیلوس
fi:Lactobacillus acidophilus, L. acidophilus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, the xx:Lactobacillus acidophilus, L. acidophilus means that the xx: translation will be used for all languages that don't have another translation, so we do not need to add it. It does not hurt though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact a few iterations ago I removed all these.

@stephanegigandet stephanegigandet merged commit f7867b5 into main Oct 6, 2022
@stephanegigandet stephanegigandet deleted the fi-ingredients-2 branch October 6, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants