Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove old carbon footprint fields #7541

Merged
merged 5 commits into from
Oct 19, 2022
Merged

fix: remove old carbon footprint fields #7541

merged 5 commits into from
Oct 19, 2022

Conversation

stephanegigandet
Copy link
Contributor

This is to remove old carbon footprint fields (and associated computations) we implemented before the Eco-Score.

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 13, 2022 16:21
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Oct 18, 2022
alexgarel
alexgarel approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just to be sure: carbon_footprint.tt.json is unrelated right ?

@stephanegigandet
Copy link
Contributor Author

Just to be sure: carbon_footprint.tt.json is unrelated right ?

It's unrelated, it's computed from Agribalyse.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit d5e459d into main Oct 19, 2022
@alexgarel alexgarel deleted the remove-old-carbon-footprint branch October 19, 2022 17:36
@alexgarel alexgarel mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Display Food.pm 🥗 Ingredients update all products
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel