Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gulp-terser dependencies conflict in npm for tagify and gulp-terser-js / gulp-min #7662

Closed
teolemon opened this issue Nov 7, 2022 · 4 comments
Closed

gulp-terser dependencies conflict in npm for tagify and gulp-terser-js / gulp-min #7662

teolemon opened this issue Nov 7, 2022 · 4 comments
Labels
🥤 Gulp ✅ Task

Comments

@teolemon
Copy link
Member

teolemon commented Nov 7, 2022

What

  • Country taxonomy is probably not built automatically on .net

image
@stephanegigandet stephanegigandet changed the title Country taxonomy is probably not built automatically on .net https://static.openfoodfacts.net/js/dist/select2.min.js not found on .net Nov 8, 2022
@stephanegigandet
Copy link
Contributor

Probably due to the mass update of dependencies from 2 weeks ago.

`(SyntaxError) Unexpected token: punc (.) (line : 26, col : 8351).
in : /opt/product-opener/node_modules/@yaireo/tagify/dist/tagify.min.js

[15:02:57] 'copyJs' errored after 5.06 s
[15:02:57] SyntaxError in plugin "gulp-terser-js"
Message:
Unexpected token: punc (.)
Details:
filename: tagify.min.js
line: 26
col: 8350
pos: 9598
filePath: /opt/product-opener/node_modules/@yaireo/tagify/dist/tagify.min.js
fileContent: /**

Seems related: yairEO/tagify#1066

@stephanegigandet
Copy link
Contributor

gulp-community/gulp-terser-js#28 is still open

stephanegigandet added a commit that referenced this issue Nov 8, 2022
@stephanegigandet
fix: downgrade tagify #7662
4cebde9
@stephanegigandet
Copy link
Contributor

Downgrading tagify to 4.12. Also fixes #7642

@stephanegigandet stephanegigandet mentioned this issue Nov 8, 2022
Merged
@stephanegigandet stephanegigandet changed the title https://static.openfoodfacts.net/js/dist/select2.min.js not found on .net gulp-terser dependencies conflict in npm for tagify and gulp-terser-js / gulp-min Nov 8, 2022
alexgarel pushed a commit that referenced this issue Nov 8, 2022
@stephanegigandet
fix: downgrade tagify to solve npm dependencies conflict (#7670)
8ed94b8 
* fix: uncheck pro checkbox unless on pro platform
* fix: downgrade tagify #7662
@alexgarel
Copy link
Member

I think it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🥤 Gulp ✅ Task
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexgarel @teolemon @stephanegigandet